Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9883 )
Change subject: [tools] ksck improvements [3/n]: master consensus checks ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc@134 PS5, Line 134: ksck_cstate->type = cstate.has_pending_config() ? shouldn't these two be grouped under a single if (cstate.has_pending_config()) { } else { } block? http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc@293 PS5, Line 293: uuid > If we don't already have this listed somewhere, maybe adding `master->addre I agree and based on the usages below I believe this method could return uuid + master address in every case. -- To view, visit http://gerrit.cloudera.org:8080/9883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1015854759debb3f1acf4bf9eb143260547f4a4b Gerrit-Change-Number: 9883 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 09 Apr 2018 20:41:00 +0000 Gerrit-HasComments: Yes
