Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9948 )

Change subject:  Add GetFlags endpoint and tool
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9948/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9948/3//COMMIT_MSG@17
PS3, Line 17:           flag          |                     value               
      | default? |      tags
> Should we omit the 'default?' column whenever we run such that only non-def
No, I think consistent output is more important for parsing than omitting a 
column that options may imply has a constant value.


http://gerrit.cloudera.org:8080/#/c/9948/3/src/kudu/server/generic_service.cc
File src/kudu/server/generic_service.cc:

http://gerrit.cloudera.org:8080/#/c/9948/3/src/kudu/server/generic_service.cc@100
PS3, Line 100:     flag->set_is_default(entry.second.current_value == 
entry.second.default_value);
> entry.second.is_default would be simpler no?
It's not the same thing. The google CommandLineFlagInfo struct's is_default is 
true if the flag has not been set-- meaning it is false if the flag has been 
explicitly set to its default value. The is_default of Flag PB message is true 
if the flag has its default value, regardless of whether it was explicitly set 
to that value or not.

I'll rename it to is_default_value so different things have different names.


http://gerrit.cloudera.org:8080/#/c/9948/3/src/kudu/tools/tool_action_common.h
File src/kudu/tools/tool_action_common.h:

http://gerrit.cloudera.org:8080/#/c/9948/3/src/kudu/tools/tool_action_common.h@107
PS3, Line 107: Gets
> Nit: Prints
Done



--
To view, visit http://gerrit.cloudera.org:8080/9948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia35b4261099c1a3c6e2ff68e907c84df9a7ff699
Gerrit-Change-Number: 9948
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Tue, 10 Apr 2018 07:48:38 +0000
Gerrit-HasComments: Yes

Reply via email to