Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9883 )
Change subject: [tools] ksck improvements [3/n]: master consensus checks ...................................................................... Patch Set 8: Verified+1 (4 comments) IWYU's suggestion is wrong- implementing it breaks the build http://gerrit.cloudera.org:8080/#/c/9883/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9883/7//COMMIT_MSG@13 PS7, Line 13: Here's a sample matrix when a master is down: > nit: this isn't just "a master is down", right? It's the wrong uuid case? No this is what it looks like when a master is down. B = D, but we can't tell that if we can't get a UUID from B. In the tablet server case we have a uuid for B from the master. http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc@293 PS5, Line 293: > I agree this would make the code a little clearer but I think we should lea Refactored so the uuid of a master with unknown uuid is always kDummyUuid and then the address in parens, so this method goes away. http://gerrit.cloudera.org:8080/#/c/9883/5/src/kudu/tools/ksck.cc@461 PS5, Line 461: : return table.PrintTo(out); > The scripts should be easy to rewrite though. To keep backwards compatibili Done http://gerrit.cloudera.org:8080/#/c/9883/6/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/9883/6/src/kudu/tools/ksck.cc@150 PS6, Line 150: for (const auto& pb : peers) { > these seem to be unused now Done -- To view, visit http://gerrit.cloudera.org:8080/9883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1015854759debb3f1acf4bf9eb143260547f4a4b Gerrit-Change-Number: 9883 Gerrit-PatchSet: 8 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 10 Apr 2018 19:20:57 +0000 Gerrit-HasComments: Yes
