Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8313 )

Change subject: KUDU-2191 (10/n): Hive Metastore notification log event listener
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8313/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/8313/7/src/kudu/master/catalog_manager.cc@3949
PS7, Line 3949:   // It wouldn't typically be correct to write to the field 
under only a read
              :   // lock, however this instance is safe because it's only 
called by the
              :   // HmsNotificationLogListenerTask singleton thread.
> I'm not a fan of this shortcut. Why not use proper locking?

In general, this whole notification log tailing is very dependent on there only 
being a single active listener.  I think the leadership lock is a pretty good 
proxy for that.  I don't think it will ever be ok to start calling these APIs 
from anywhere but the listening thread without some other major changes.  Nor 
can I think of a motivation to do so.



--
To view, visit http://gerrit.cloudera.org:8080/8313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775
Gerrit-Change-Number: 8313
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 11 Apr 2018 22:50:13 +0000
Gerrit-HasComments: Yes

Reply via email to