Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10028 )
Change subject: HmsCatalog: fix bug in reconnection backoff logic ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10028/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/10028/1/src/kudu/integration-tests/master_hms-itest.cc@279 PS1, Line 279: // HmsCatalog throttles reconnections, so it's necessary to wait out the backoff. : table_alterer.reset(client_->NewTableAlterer("db.c")); : ASSERT_OK(table_alterer->RenameTo("db.a")->Alter()); Do we have to reconstruct the TableAlterer each time? Couldn't we just call Alter() in the body of the ASSERT_EVENTUALLY? Below too. -- To view, visit http://gerrit.cloudera.org:8080/10028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I726283ec8332d16942c82c73492709de4323a43d Gerrit-Change-Number: 10028 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 12 Apr 2018 00:14:08 +0000 Gerrit-HasComments: Yes
