Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 )
Change subject: [tools] minor enhancements on 'kudu cluster ksck' output ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@536 PS2, Line 536: "Total:\n tables $0\n tablets $1\n replicas $2" > nit: I prefer to put output like this in a table, e.g. Good idea. I appreciate you overcome the issue with non-fixed fonts :) Maybe, you could just do that in an independent console editor and that copy-paste the result in here. However, from what I see here, the gerrit uses fixed-width font in the result rendering. http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@870 PS2, Line 870: const int table_num_replicas = table->num_replicas(); > nit: Eliminate the local in favor of ts->replication_factor Done -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 13 Apr 2018 01:49:13 +0000 Gerrit-HasComments: Yes
