Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10057 )
Change subject: [java] KUDU-2407: Fix leaked protubuf generated class ...................................................................... Patch Set 1: It is and we don't. It was added in 1.5.0 and I can't see a reason anyone would use it. We could just mark it as private with an interface annotation if you think thats better. I think the risk of leaving it public is potential breakage in the exposed Protobuf generated Role class that we don't have control over. -- To view, visit http://gerrit.cloudera.org:8080/10057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907 Gerrit-Change-Number: 10057 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 13 Apr 2018 16:43:12 +0000 Gerrit-HasComments: No
