Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG@18
PS1, Line 18: have Gauva marked as a dependency.
> what's the advantage of eliminating guava usage? don't we shade it anyway?
It wasn't a primary goal, just something I noticed when making this change. I 
have updated the commit message to make that more clear.

The change to not use Guava was smaller than a change to add it as a 
dependency. And since it's not really used a lot I didn't see a reason to keep 
it.

We actually weren't shading Guava in kudu-spark, kudu-spark-tools or kudu-hive. 
I think that's mostly because they weren't listed as dependencies and were 
pulled in transitively.

Even if we shade Guava while we continue to use Maven as our build tool we can 
still get weird compatibility issues due to Mavens shading order issues. I am 
trying to finish up the Gradle work asap so that's no longer a problem.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:03:37 +0000
Gerrit-HasComments: Yes

Reply via email to