Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10096 )
Change subject: [Java] Fix Guava transitive dependecies ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10096/3//COMMIT_MSG@16 PS3, Line 16: d’s Adds http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle File java/kudu-client-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/10096/3/java/kudu-client-tools/build.gradle@24 PS3, Line 24: compile(libs.guava) { transitive = false } Is there a way to factor this out into a common configuration across all submodules? For instance Maven has the dependenciesManagement section that you can put in the parent pom to apply configurations like this to all submodules. I'd suggest doing that for the maven part of this patch as well, except I'm hoping all this work you're putting in is going towards scapping maven anyway, in which case it's not a big deal. -- To view, visit http://gerrit.cloudera.org:8080/10096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f1f6e762629c1dea30589a1ade1f3da6de6ad3d Gerrit-Change-Number: 10096 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 19 Apr 2018 16:54:35 +0000 Gerrit-HasComments: Yes
