David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7221 )
Change subject: Simplify OpId/Timestamp assignment and make it atomic ...................................................................... Patch Set 24: (7 comments) http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@26 PS24, Line 26: it > t ? Done http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@26 PS24, Line 26: also > drop 'also'? Done http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@29 PS24, Line 29: non-atomically with > separately from I think non-atomically here is better. after all non-separately doesn't necessarily mean atomically http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@35 PS24, Line 35: with > it ? Done http://gerrit.cloudera.org:8080/#/c/7221/24//COMMIT_MSG@39 PS24, Line 39: , > replace with stop/dot ? Done http://gerrit.cloudera.org:8080/#/c/7221/21/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: http://gerrit.cloudera.org:8080/#/c/7221/21/src/kudu/tablet/transactions/transaction_driver.cc@324 PS21, Line 324: DCHECK_EQ(driver_type, consensus::LEADER); > would it be correct here to add a DCHECK_EQ(transaction_->type(), consensus Done http://gerrit.cloudera.org:8080/#/c/7221/24/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: http://gerrit.cloudera.org:8080/#/c/7221/24/src/kudu/tablet/transactions/transaction_driver.cc@69 PS24, Line 69: using std::unique_ptr; > warning: using decl 'unique_ptr' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/7221 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bedcc5c3708d06f48131f34ea14c835867b4800 Gerrit-Change-Number: 7221 Gerrit-PatchSet: 24 Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 23 Apr 2018 21:15:49 +0000 Gerrit-HasComments: Yes
