Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10161 )
Change subject: iwyu: add proper dependency on thrift generated code, check for iwyu errors ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/10161/1/build-support/iwyu.py@52 PS1, Line 52: r'^.+?:\d+:\d+:\s*' > the FATAL_ERROR case is already handled explicitly in _run_iwyu_tool. I add Ah, yes -- I found that yesterday as well after reviewing that patch. Thank you for addressing this tiny nit. -- To view, visit http://gerrit.cloudera.org:8080/10161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie44f25ebc160c587eb11b4b4730095ee1e6c4fde Gerrit-Change-Number: 10161 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 24 Apr 2018 19:59:41 +0000 Gerrit-HasComments: Yes
