Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10102 )
Change subject: Re-enable IWYU checks on HMS module ...................................................................... Patch Set 3: > Rebased. I'm a little confused, because I'm not getting iwyu > errors before _or_ after applying this patch on an internal build > machine. We'll see what gerrit says. I think the code cleanups in > this patch are worth landing. Yeah, I think the reason you didn't see errors on your local build machine is that most likely Thrift-related files were already generated when you ran the 'iwyu' target. However, in case of Jenkins slaves for pre-commit builds, the IWYU configuration just run 'make iwyu' target before as is, without building the rest of the sources. -- To view, visit http://gerrit.cloudera.org:8080/10102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63e5f1ca6a480f22ede83acde6baea8e2f563e8a Gerrit-Change-Number: 10102 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 25 Apr 2018 00:59:26 +0000 Gerrit-HasComments: No
