Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10215 )
Change subject: [Java] Check in the Gradle wrapper properties ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10215/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10215/1//COMMIT_MSG@8 PS1, Line 8: : We were downloading the properties file, but that can result in : using and outdated Gradle wrapper distribution. > Given that downloading the properties file was intentional (see commit cc0b The gradle wrapper jar doesn't really change from version to version and is only used to define how to download the distribution. So it's okay to lazily fetch that jar even when our gradle version changes. The distribution to use is defined by the wrapper properties file. If the user has used an older version and then pulls in a new update that changes the gradle version, the code would see the properties file exists and not download the new one. This would leave the wrapper running an older version than the build defines. We download the jar because we shouldn't have binary files checked in. But we should check in the properties file because the build version used should be defined by the checked in code. The other issue is the downloaded properties file is always pointing to the last release candidate for gradle instead of the release itself (due to the gradle release process I suppose). This is likely functionally equivalent but not optimal. -- To view, visit http://gerrit.cloudera.org:8080/10215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a772d5e093be29fcbabcbd8324bd6434fb33beb Gerrit-Change-Number: 10215 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 27 Apr 2018 03:46:28 +0000 Gerrit-HasComments: Yes
