Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10151 )
Change subject: [tools] ksck improvements [6/n]: Refactor result handling ...................................................................... [tools] ksck improvements [6/n]: Refactor result handling This patch refactors ksck so the results of the checks are collected in a new KsckResults struct. Printing results is now a matter of iterating over the KsckResults struct and formatting the information within it. Furthermore, the KsckResults struct also serves as a programmatic access point to the results of ksck, which can be used for other things like rebalancing, auto-repair, or machine-readable printing. There's also a couple of bonus changes: - Added Ksck::Run and Ksck::RunAndPrintResults methods, which simplify running all ksck checks and printing the results, as is done in the ksck CLI tool and in ClusterVerifier. - Add the changes in https://gerrit.cloudera.org/#/c/10054/, which were about to be committed but would've needed to be redone a bit to fit with this refactor. Change-Id: Id8de619996b6cd753e6a9c01b1b60810a873e609 Reviewed-on: http://gerrit.cloudera.org:8080/10151 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc A src/kudu/tools/ksck_results.cc A src/kudu/tools/ksck_results.h M src/kudu/tools/tool_action_cluster.cc M src/kudu/tools/tool_action_tablet.cc 10 files changed, 1,195 insertions(+), 879 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8de619996b6cd753e6a9c01b1b60810a873e609 Gerrit-Change-Number: 10151 Gerrit-PatchSet: 15 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]>
