Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10266 )
Change subject: Add warnings and docs on setting block_cache_capacity_mb too high ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10266/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10266/2//COMMIT_MSG@12 PS2, Line 12: ;wq typo http://gerrit.cloudera.org:8080/#/c/10266/2/src/kudu/cfile/block_cache.cc File src/kudu/cfile/block_cache.cc: http://gerrit.cloudera.org:8080/#/c/10266/2/src/kudu/cfile/block_cache.cc@84 PS2, Line 84: int64 mpt = process_memory::MemoryPressureThreshold(); : if (capacity > mpt) { : LOG(ERROR) << "Block cache capacity exceeds the memory pressure threshold " : "(" << capacity << " bytes vs. " << mpt << " bytes). This " : "will cause instability and harmful flushing behavior. " : "Consider lowering --block_cache_capacity_mb or raising " : "--memory_limit_hard_bytes."; : } else if (capacity > mpt / 2) { : LOG(WARNING) << "Block cache capacity exceeds 50% of the memory pressure threshold " : "(" << capacity << " bytes vs. 50% of " << mpt << " bytes). " : " This may cause performance problems. Consider lowering " : "--block_cache_capacity_mb or raising --memory_limit_hard_bytes."; : } Is it possible to perform the verification of these parameters in GROUP_FLAG_VALIDATOR for the --block_cache_capacity_mb flag? Then it would be possible to modify the behavior and refuse to start (if no appropriate --force_xxx flag specified) for the case of capacity > mpt. -- To view, visit http://gerrit.cloudera.org:8080/10266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia99fa95c578235beb3a1c72a33a22b4d8ff4800c Gerrit-Change-Number: 10266 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 01 May 2018 20:53:45 +0000 Gerrit-HasComments: Yes
