Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10169 )

Change subject: KUDU-2214 Update logging to differentiate voting while 
copying/tombstoned
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:

http://gerrit.cloudera.org:8080/#/c/10169/1/src/kudu/integration-tests/tablet_copy-itest.cc@1385
PS1, Line 1385:     Status s = itest::RequestVote(new_replica_ts, tablet_id, 
kCandidateUuid,
Alternatively, we can use this test for this purpose and instead of 
RequestVote() calls I think repeated StartElection() calls would be more 
appropriate and easier to manage.

At the end of the test, we can grep the logs located in the external mini 
cluster directories. See src/kudu/integration-tests/log-rolling-itest.cc for an 
example of how to build the path to those glog files.

So we could grep for the expected messages there.



--
To view, visit http://gerrit.cloudera.org:8080/10169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07007601d0a86d6161065629ba167121a33635d6
Gerrit-Change-Number: 10169
Gerrit-PatchSet: 1
Gerrit-Owner: Fengling Wang <[email protected]>
Gerrit-Reviewer: Fengling Wang <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Tue, 01 May 2018 21:15:10 +0000
Gerrit-HasComments: Yes

Reply via email to