Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/3946 )
Change subject: tool: improve format for dumping a rowset ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3946/4/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/3946/4/src/kudu/tools/tool_action_local_replica.cc@630 PS4, Line 630: scoped_refptr nit: I saw std::unique_ptr is used in this file, so why not to use std::unique_ptr here as well? -- To view, visit http://gerrit.cloudera.org:8080/3946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f1d08e08d2a3d20a87e49bb5338bf0585bd8e40 Gerrit-Change-Number: 3946 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 02 May 2018 18:21:57 +0000 Gerrit-HasComments: Yes
