Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8280 )
Change subject: mini-cluster: support parallel multi-master clusters ...................................................................... Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/8280/5/src/kudu/integration-tests/master_migration-itest.cc File src/kudu/integration-tests/master_migration-itest.cc: http://gerrit.cloudera.org:8080/#/c/8280/5/src/kudu/integration-tests/master_migration-itest.cc@89 PS5, Line 89: // Collect and keep alive the set of master sockets bound with SO_REUSEPORT. > Can you add some comments here explaining why we're doing this? Done http://gerrit.cloudera.org:8080/#/c/8280/7/src/kudu/integration-tests/master_migration-itest.cc File src/kudu/integration-tests/master_migration-itest.cc: http://gerrit.cloudera.org:8080/#/c/8280/7/src/kudu/integration-tests/master_migration-itest.cc@89 PS7, Line 89: SO_REUSEPOR > SO_REUSEPORT Done http://gerrit.cloudera.org:8080/#/c/8280/7/src/kudu/integration-tests/registration-test.cc File src/kudu/integration-tests/registration-test.cc: http://gerrit.cloudera.org:8080/#/c/8280/7/src/kudu/integration-tests/registration-test.cc@272 PS7, Line 272: const int startup_rows_inserted = GetCatalogMetric(METRIC_rows_inserted); : : // Add a table, make sure it reports itself. > Hmm, the fact that you had to add this means the patch has changed some sem Done http://gerrit.cloudera.org:8080/#/c/8280/5/src/kudu/mini-cluster/internal_mini_cluster.cc File src/kudu/mini-cluster/internal_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/8280/5/src/kudu/mini-cluster/internal_mini_cluster.cc@149 PS5, Line 149: if (num_masters > 1) { : mini_master->SetMasterAddresses(master_rpc_addrs); : } > Not sure I understand the new condition; if num_masters was 0, won't this l Good catch, this was supposed to be > 1. The Internal mini cluster already had the equivalent. -- To view, visit http://gerrit.cloudera.org:8080/8280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b0ff7bfc179d8fdb1ed306d1bbd12acddeb060c Gerrit-Change-Number: 8280 Gerrit-PatchSet: 8 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 03 May 2018 19:13:30 +0000 Gerrit-HasComments: Yes
