Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 )
Change subject: KUDU-2191: Metadata Upgrade Tool ...................................................................... Patch Set 12: (2 comments) Just passing through... http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/mini-cluster/external_mini_cluster.h@140 PS12, Line 140: // If true, set up a Hive Metastore as part of this ExternalMiniCluster. : // : // Default: false. : bool enable_hive_metastore; : : // If true, set up a Hive Metastore and enable Kudu Hive Metastore integration. : // : // Default: false. : bool enable_metastore_integration; Why do we need both of these? It seems like they overlap; perhaps this can be converted into a tri-state enum class instead? http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/10075/12/src/kudu/tools/tool.proto@43 PS12, Line 43: // Whether or not to create a Hive Metastore. : optional bool enable_hive_metastore = 7; : : // Whether or not to create a Hive Metastore and enable the HMS integration. : optional bool enable_metastore_integration = 9; Same feedback. -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 12 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 04 May 2018 18:22:48 +0000 Gerrit-HasComments: Yes
