Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10286 )
Change subject: Add ExtractBool method to JsonReader ...................................................................... Patch Set 3: Verified+1 (4 comments) Flake http://gerrit.cloudera.org:8080/#/c/10286/1/src/kudu/util/jsonreader-test.cc File src/kudu/util/jsonreader-test.cc: http://gerrit.cloudera.org:8080/#/c/10286/1/src/kudu/util/jsonreader-test.cc@163 PS1, Line 163: ASSERT_TRUE(r.ExtractBool(r.root(), nullptr, nullptr).IsInvalidArgument()); > warning: use nullptr [modernize-use-nullptr] Done http://gerrit.cloudera.org:8080/#/c/10286/1/src/kudu/util/jsonreader-test.cc@164 PS1, Line 164: ASSERT_TRUE(r.ExtractInt32(r.root(), nullptr, nullptr).IsInvalidArgument()); > warning: use nullptr [modernize-use-nullptr] Done http://gerrit.cloudera.org:8080/#/c/10286/1/src/kudu/util/jsonreader-test.cc@165 PS1, Line 165: ASSERT_TRUE(r.ExtractInt64(r.root(), nullptr, nullptr).IsInvalidArgument()); > warning: use nullptr [modernize-use-nullptr] Done http://gerrit.cloudera.org:8080/#/c/10286/1/src/kudu/util/jsonreader-test.cc@166 PS1, Line 166: ASSERT_TRUE(r.ExtractString(r.root(), nullptr, nullptr).IsInvalidArgument()); > warning: use nullptr [modernize-use-nullptr] Done -- To view, visit http://gerrit.cloudera.org:8080/10286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2888fc150aaf3db5db01d6135c9d387db39cc179 Gerrit-Change-Number: 10286 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 05 May 2018 03:50:34 +0000 Gerrit-HasComments: Yes
