Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10324 )
Change subject: [java] Fix TestUtils on Java 9+ ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10324/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/10324/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java@131 PS1, Line 131: if (!(procCls.getName().equals(UNIX_PROCESS_CLS_NAME) || : procCls.getName().equals(PROCESS_IMPL_CLS_NAME))) { : throw new IllegalArgumentException("stopProcess() expects objects of class " + : UNIX_PROCESS_CLS_NAME + " or " + PROCESS_IMPL_CLS_NAME + ", but " + procCls.getName() + : " was passed in instead!"); : } > Maybe just drop this and let the reflection below throw if the class is all Yeah, I am onboard with that simplification. -- To view, visit http://gerrit.cloudera.org:8080/10324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied4ffdca10dc5a0cdc0516964bf6202fd3871f30 Gerrit-Change-Number: 10324 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 07 May 2018 16:07:07 +0000 Gerrit-HasComments: Yes
