Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10338
to review the following change.
Change subject: consensus: include peer address in leader election messages
......................................................................
consensus: include peer address in leader election messages
This additional info makes it easier to read and interpret consensus
traffic in log messages.
The new log lines look like this:
I0507 18:16:21.487584 1667 raft_consensus.cc:457] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877 [term 0
FOLLOWER]: Starting pre-election with config: opid_index: -1 OBSOLETE_local:
false peers { permanent_uuid: "ad85c27590a848a2bdd89684da1db336" member_type:
VOTER last_known_addr { host: "127.1.68.1" port: 44207 } } peers {
permanent_uuid: "c2e1ad2aaffb48b08e018b4999c45612" member_type: VOTER
last_known_addr { host: "127.1.68.2" port: 46305 } } peers { permanent_uuid:
"e8523a05f7dd4d90977c7ccf00cb0877" member_type: VOTER last_known_addr { host:
"127.1.68.4" port: 46653 } }
I0507 18:16:21.487962 1667 leader_election.cc:243] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877
[CANDIDATE]: Term 1 pre-election: Requesting pre-vote from peer
ad85c27590a848a2bdd89684da1db336 (127.1.68.1:44207)
I0507 18:16:21.488155 1667 leader_election.cc:243] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877
[CANDIDATE]: Term 1 pre-election: Requesting pre-vote from peer
c2e1ad2aaffb48b08e018b4999c45612 (127.1.68.2:46305)
I0507 18:16:21.491686 1410 tablet_service.cc:998] Received
RequestConsensusVote() RPC: tablet_id: "6854ca4380c24f3a865458747235c4a3"
candidate_uuid: "e8523a05f7dd4d90977c7ccf00cb0877" candidate_term: 1
candidate_status { last_received { term: 0 index: 0 } } ignore_live_leader:
false dest_uuid: "ad85c27590a848a2bdd89684da1db336" is_pre_election: true
I0507 18:16:21.491680 1470 tablet_service.cc:998] Received
RequestConsensusVote() RPC: tablet_id: "6854ca4380c24f3a865458747235c4a3"
candidate_uuid: "e8523a05f7dd4d90977c7ccf00cb0877" candidate_term: 1
candidate_status { last_received { term: 0 index: 0 } } ignore_live_leader:
false dest_uuid: "c2e1ad2aaffb48b08e018b4999c45612" is_pre_election: true
I0507 18:16:21.491806 1410 raft_consensus.cc:2704] T
6854ca4380c24f3a865458747235c4a3 P ad85c27590a848a2bdd89684da1db336: Snoozing
failure detection for 1.976s (vote granted)
I0507 18:16:21.491806 1470 raft_consensus.cc:2704] T
6854ca4380c24f3a865458747235c4a3 P c2e1ad2aaffb48b08e018b4999c45612: Snoozing
failure detection for 1.870s (vote granted)
I0507 18:16:21.491855 1470 raft_consensus.cc:2219] T
6854ca4380c24f3a865458747235c4a3 P c2e1ad2aaffb48b08e018b4999c45612 [term 0
FOLLOWER]: Leader pre-election vote request: Granting yes vote for candidate
e8523a05f7dd4d90977c7ccf00cb0877 in term 0.
I0507 18:16:21.491855 1410 raft_consensus.cc:2219] T
6854ca4380c24f3a865458747235c4a3 P ad85c27590a848a2bdd89684da1db336 [term 0
FOLLOWER]: Leader pre-election vote request: Granting yes vote for candidate
e8523a05f7dd4d90977c7ccf00cb0877 in term 0.
I0507 18:16:21.492164 1576 leader_election.cc:379] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877
[CANDIDATE]: Term 1 pre-election: Vote granted by peer
ad85c27590a848a2bdd89684da1db336 (127.1.68.1:44207)
I0507 18:16:21.492213 1576 leader_election.cc:270] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877
[CANDIDATE]: Term 1 pre-election: Election decided. Result: candidate won.
I0507 18:16:21.492254 1578 leader_election.cc:379] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877
[CANDIDATE]: Term 1 pre-election: Vote granted by peer
c2e1ad2aaffb48b08e018b4999c45612 (127.1.68.2:46305)
I0507 18:16:21.492349 1667 raft_consensus.cc:2704] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877: Snoozing
failure detection for 1.884s (election complete)
I0507 18:16:21.492388 1667 raft_consensus.cc:2511] T
6854ca4380c24f3a865458747235c4a3 P e8523a05f7dd4d90977c7ccf00cb0877 [term 0
FOLLOWER]: Leader pre-election won for term 1
Change-Id: I2ec311bb6d892a42f64a77ebbde6e6d5ddf68724
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/leader_election.h
6 files changed, 81 insertions(+), 54 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10338/1
--
To view, visit http://gerrit.cloudera.org:8080/10338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ec311bb6d892a42f64a77ebbde6e6d5ddf68724
Gerrit-Change-Number: 10338
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
