Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10355 )
Change subject: [thirdparty] Fix failing openssl check on MacOS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10355/2/thirdparty/preflight.py File thirdparty/preflight.py: http://gerrit.cloudera.org:8080/#/c/10355/2/thirdparty/preflight.py@134 PS2, Line 134: def check_openssl(): This is good, but it's missing the other part of build-thirdparty.sh which deals with homebrew: # Build against the Macports or Homebrew OpenSSL versions, in order to match # the Kudu build. if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then # If OpenSSL is built via Homebrew, pkg-config does not report on cflags. homebrew_openssl_dir=/usr/local/opt/openssl if [ -d $homebrew_openssl_dir ]; then OPENSSL_CFLAGS="-I$homebrew_openssl_dir/include" OPENSSL_LDFLAGS="-L$homebrew_openssl_dir/lib" fi fi -- To view, visit http://gerrit.cloudera.org:8080/10355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieffc39f6e9bf5744b1119826375d36ee1035ccde Gerrit-Change-Number: 10355 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 09 May 2018 15:18:28 +0000 Gerrit-HasComments: Yes
