Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10293/2/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/2/src/kudu/tools/ksck_remote.cc@165 PS2, Line 165: return Status::UuidMismatch(Substitute("ID reported by tablet server ($0) doesn't " > that makes sense, although I'm not sure how this should be implemented. Ksc What do you think about changing the signature of FetchInfo() to: Status FetchInfo(KsckServerHealth* health); The conditional logic in ksck.cc to select WRONG_SERVER_UUID vs UNAVAILABLE vs HEALTHY could then be done here instead. The same could be done for the masters (not necessary, but might be nice for symmetry). This also messes up some other logic in ksck.cc but nothing that can't be worked around. Curious if Will has any thoughts on this. -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 10 May 2018 03:24:12 +0000 Gerrit-HasComments: Yes
