Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10342 )
Change subject: [flags] run validators after processing help flags ...................................................................... [flags] run validators after processing help flags Run flag validators (both individual and group ones) after processing the help flags. Also, this is a follow-up for 297b72bd26cdd546f0a73cda7487c80566388492: the default value for the --force_block_cache_capacity flag is set to 'true' everywhere but in master and tablet server. Otherwise, corresponding group validator could strike while running binaries that link the cfile library (e.g. the kudu CLI tool) at machines with less than 256 MB of available memory. Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Reviewed-on: http://gerrit.cloudera.org:8080/10342 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/cfile/block_cache.cc M src/kudu/consensus/CMakeLists.txt M src/kudu/integration-tests/CMakeLists.txt M src/kudu/master/master_main.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/tablet_server_main.cc M src/kudu/util/flags.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 10 files changed, 50 insertions(+), 42 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I51f263890c91251f0d13c826c40dfd20fe284b59 Gerrit-Change-Number: 10342 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
