Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10076 )
Change subject: KUDU-2287 Expose election failures as metrics ...................................................................... Patch Set 13: (2 comments) Approach looks good. Needs a test for each metric. http://gerrit.cloudera.org:8080/#/c/10076/13/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/10076/13/src/kudu/consensus/raft_consensus.h@868 PS13, Line 868: time_since_stable_leader_ This member is supposed to represent the moment in time when this replica concluded there's no longer a leader, while there's no leader. This means the name is confusing because it sounds like it is a duration. Howabout "time_stable_leader_lost" or something? Additionally, during periods of stable leadership there is no proper value for this member. I think you have been using MonoTime::Min() as a sentinel for this; perhaps use a boost::optional<MonoTime> so the types more closely mirror the logic? http://gerrit.cloudera.org:8080/#/c/10076/13/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/10076/13/src/kudu/consensus/raft_consensus.cc@162 PS13, Line 162: "The time elapsed without successful election since majority was " : "lost in nanoseconds." This description is confusing to me. IIUC, this metric is the amount of time in nanoseconds since this node detected a failure of the leader, or 0 is a leader is believed alive? -- To view, visit http://gerrit.cloudera.org:8080/10076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b25df258cdba7bdae7bb2d7b4eb3d73b53425c3 Gerrit-Change-Number: 10076 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 10 May 2018 21:02:34 +0000 Gerrit-HasComments: Yes
