Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10424 )
Change subject: [java] Remove private method usage in kudu-mapreduce ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java: http://gerrit.cloudera.org:8080/#/c/10424/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java@1106 PS1, Line 1106: public String toString() { > I wonder if we'd be better served building a serializer/deserializer around I agree. The same may be true for scan token serialization. -- To view, visit http://gerrit.cloudera.org:8080/10424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce54f715f970d1c7f9433e39af27d618e73fe6a Gerrit-Change-Number: 10424 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 17:40:23 +0000 Gerrit-HasComments: Yes
