Hello Todd Lipcon, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10430 to review the following change. Change subject: KUDU-2427: only add -fno-sized-deallocation for C++ files ...................................................................... KUDU-2427: only add -fno-sized-deallocation for C++ files Ubuntu 18.04 has a gcc that's new enough to support -fsized-deallocation. But, if -fno-sized-deallocation is added to a C file's compilation flags, the compiler will emit a warning: cc1: warning: command line option ‘-fno-sized-deallocation’ is valid for C++/ObjC++ but not for C The problem is that we want to apply this flag only to "exported" targets, but we have one such target (gutil_exported) that has both C and C++ files in it. To address this, we can use a cmake generator expression[1] to conditionally add the flag only to the C++ files in the target. This means adding the flag with target_compile_options(), as set_target_properties() does not support generator expressions. 1. https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html Change-Id: Ib2fbd94f19495eb48119d8f9ecb6fdceee2387c3 --- M CMakeLists.txt 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/10430/1 -- To view, visit http://gerrit.cloudera.org:8080/10430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2fbd94f19495eb48119d8f9ecb6fdceee2387c3 Gerrit-Change-Number: 10430 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>