Hello Todd Lipcon,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10429

to review the following change.


Change subject: build: only call find_package on gperftools if we're going to 
use it
......................................................................

build: only call find_package on gperftools if we're going to use it

Since commit e0a743d24, TSAN builds emit the following non-fatal warning
when cmake is run:

  -- Could NOT find GOOGLE_PERFTOOLS (missing: TCMALLOC_SHARED_LIB 
TCMALLOC_STATIC_LIB PROFILER_SHARED_LIB PROFILER_STATIC_LIB 
GOOGLE_PERFTOOLS_INCLUDE_DIR)

Moving the find_package() call into the gperftools condition means we won't
try to look for it at all when we're not going to use it.

Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/10429/1
--
To view, visit http://gerrit.cloudera.org:8080/10429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
Gerrit-Change-Number: 10429
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to