Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9900 )
Change subject: Fix flaky file_cache-test ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/fs/block_manager-stress-test.cc File src/kudu/fs/block_manager-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/fs/block_manager-stress-test.cc@543 PS2, Line 543: PeriodicOpenFdChecker checker(this->env_, this->GetTestPath("*"), Same. Perhaps this should be the default value? Or is it not possible to call GetTestPath from file_cache-test-util? http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/util/file_cache-test.cc File src/kudu/util/file_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/9900/2/src/kudu/util/file_cache-test.cc@75 PS2, Line 75: return kudu::CountOpenFds(env_, GetTestPath("*")); Add a comment explaining why we're constraining to GetTestPath(*)? http://gerrit.cloudera.org:8080/#/c/9900/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/9900/1/src/kudu/util/test_util.cc@337 PS1, Line 337: CHECK(safe_strto32(c, &fd)) << "Unexpected file in fd list: " << c; JoinPathSegments instead? -- To view, visit http://gerrit.cloudera.org:8080/9900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bd51c267fbc7dc954d593caedf8631f261909c9 Gerrit-Change-Number: 9900 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 17 May 2018 18:15:27 +0000 Gerrit-HasComments: Yes
