Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/10438 )
Change subject: [consensus] KUDU-2443 fix replica replacement of RF=1
......................................................................
Patch Set 3:
> > LGTM but I think we should add a regression itest for KUDU-2443
>
> That's done -- the new scenarios in src/kudu/quorum_util-test.cc is
> the regression tests for KUDU-2443.
Particularly, this one is the test I think you mentioned:
{
RaftConfigPB config;
AddPeer(&config, "A", V, '+', {{"REPLACE", true}});
AddPeer(&config, "B", V, '+');
EXPECT_FALSE(ShouldAddReplica(config, 1, policy));
EXPECT_FALSE(ShouldEvictReplica(config, "A", 1, policy));
string to_evict;
ASSERT_TRUE(ShouldEvictReplica(config, "B", 1, policy, &to_evict));
EXPECT_EQ("A", to_evict);
}
--
To view, visit http://gerrit.cloudera.org:8080/10438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9da9fe6788f28b40f7adc53e23540bcdf103c1ea
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-Comment-Date: Thu, 17 May 2018 21:34:09 +0000
Gerrit-HasComments: No
