Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 )
Change subject: WIP [rebalancing] high-level rebalancing algorithm ...................................................................... Patch Set 3: (2 comments) FYI Alexey I am revising this patch while you work on the "engine" part, as we spoke about. http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc File src/kudu/tools/rebalance-algo.cc: http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc@217 PS8, Line 217: } This isn't the max server skew, it's the number of replicas on the most loaded server. http://gerrit.cloudera.org:8080/#/c/10336/8/src/kudu/tools/rebalance-algo.cc@244 PS8, Line 244: auto min_range = cnt_by_server.equal_r This is the same as checking if max_table_skew == 0 above. -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 18 May 2018 08:40:58 +0000 Gerrit-HasComments: Yes
