Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10436 )
Change subject: KUDU-1889: support openssl 1.1 ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc File src/kudu/security/ca/cert_management.cc: http://gerrit.cloudera.org:8080/#/c/10436/3/src/kudu/security/ca/cert_management.cc@345 PS3, Line 345: if (!req->req_info || > Whether or not it's safe is somewhat orthogonal: in OpenSSL 1.1 we can't ac I was mostly asking to understand why we bothered reaching into the struct in the old version. Sounds like it was due to a bug in X509_REQ_get_pubkey which has since been fixed. -- To view, visit http://gerrit.cloudera.org:8080/10436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1e1c57b5563d1a4cd926b4c4a9a3c271460be04 Gerrit-Change-Number: 10436 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 18 May 2018 17:54:22 +0000 Gerrit-HasComments: Yes
