Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10075 )
Change subject: KUDU-2191: Metadata Upgrade Tool ...................................................................... Patch Set 20: (7 comments) http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/kudu-tool-test.cc@2043 PS19, Line 2043: > repeated just below Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@69 PS19, Line 69: DEFINE_bool(enable_input, true, > I think true would be a better default here, since it's more annoying to ha Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@124 PS19, Line 124: Found orphan table $ > nit: 'Found orphan table $0.$1...' Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@159 PS19, Line 159: Failed to upgrade legacy Impala table > I think something along the lines of Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@165 PS19, Line 165: } else { > I think this lambda is obscuring things a bit. For instance the SchemaFrom Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@170 PS19, Line 170: while (!s.ok() && FLAGS_enable_input && > Would be good to have a test of this loop, just to have some coverage of th Done http://gerrit.cloudera.org:8080/#/c/10075/19/src/kudu/tools/tool_action_hms.cc@188 PS19, Line 188: if (!failures.empty()) { > LOG(WARNING) the other errors so they get surfaced Done -- To view, visit http://gerrit.cloudera.org:8080/10075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8488e1c7b04b8bedc31c83b1496b53bae49cb3 Gerrit-Change-Number: 10075 Gerrit-PatchSet: 20 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Sat, 19 May 2018 00:15:34 +0000 Gerrit-HasComments: Yes
