Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10456 )
Change subject: KUDU-2314 Add wal and metadata directories info to FsReport ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/10456/1/src/kudu/fs/log_block_manager.cc@1825 PS1, Line 1825: // Record the wal and metadata directory paths > I think it makes sense to handle this reporting at the FsManager layer inst Agreed with Andrew. The original intent behind FsReport was to allow any module from the FsManager on down to modify it. The idea is that the FsManager creates it, passes it down the stack in Open(), then prints the results. Along the way, the block manager might modify it. Or the directory manager. Or the FsManager itself, etc. -- To view, visit http://gerrit.cloudera.org:8080/10456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1fd362582ea84696db2aa64a83c6d3e86c78ae Gerrit-Change-Number: 10456 Gerrit-PatchSet: 1 Gerrit-Owner: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Fengling Wang <fw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Mon, 21 May 2018 17:14:05 +0000 Gerrit-HasComments: Yes
