Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10435 )
Change subject: KUDU-2427: retry more system calls on EINTR ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/10435/3/src/kudu/util/net/socket.cc File src/kudu/util/net/socket.cc: http://gerrit.cloudera.org:8080/#/c/10435/3/src/kudu/util/net/socket.cc@465 PS3, Line 465: Status s = Write(buf, num_to_write, &inc_num_written); : tot_written += inc_num_written; : buf += inc_nu > ah... the RETRY_ON_EINTR around SSL_read is actually a little concerning. I Yep, SSL_read() and SSL_write() seemed messy when I looked at them last time. As they say in the doc: '... The behaviour of SSL_read() depends on the underlying BIO. ...' But first of all, the corresponding change with RETRY_ON_EINTR() in tls_socket.cc looks suspicious to me: while working with OpenSSL functions, it's necessary to clean up the errors from the stack using SSL_get_error(). My another concern is that SSL_read()/SSL_write() might handle EINTR themselves. -- To view, visit http://gerrit.cloudera.org:8080/10435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cce03c4e1b2be32c1910382737526082fc99966 Gerrit-Change-Number: 10435 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 21 May 2018 18:59:10 +0000 Gerrit-HasComments: Yes
