Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10506
to review the following change.
Change subject: WIP: Improve non-matching schema error message for client
provided defaults
......................................................................
WIP: Improve non-matching schema error message for client provided defaults
In the case where the client provides a schema with an additional column
with a default, and does not provide the value of the column in the
write, the server should reject that request with a message indicating
that the client wanted the default, not that the client provided the
value for the missing column.
While we have not verified this, Will saw a case in the wild involving
alter table abort where the client appears to have not provided a value
for the column, intending to use the default, but got the error message
"Client provided column foo_bar not present in tablet".
TODO: We are not sure if the client actually provided the value but it
got projected out when printing the values being inserted or if indeed
the client was attempting to use the default from its provided schema.
Also TODO: This patch needs a test.
Change-Id: I087c130a0f19c1feb8f4c0cd3c9cc794c4a552c2
---
M src/kudu/common/row_operations.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/10506/1
--
To view, visit http://gerrit.cloudera.org:8080/10506
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I087c130a0f19c1feb8f4c0cd3c9cc794c4a552c2
Gerrit-Change-Number: 10506
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
