Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10505 )
Change subject: KUDU-702 Add block IDs to more log messages ...................................................................... Patch Set 2: > I don't see how this patch addresses KUDU-702, because all of the > additions here are for edge cases that generate WARNING or ERROR > logging, whereas KUDU-702 asks for additions to INFO-level logging. > > One of Todd's comments in KUDU-702 suggests that maybe a lot of the > existing candidates for improving are now gone. Is that the case? > If so, what is KUDU-702 now trying to achieve, and how does this > patch help achieve that? Thats right. I could not find any INFO logs to add block ids to. In case you have any suggestions where I could further add this information please let me know. Thanks ! -- To view, visit http://gerrit.cloudera.org:8080/10505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I895da1cc04ecbf006f412f06b31461b03072d32d Gerrit-Change-Number: 10505 Gerrit-PatchSet: 2 Gerrit-Owner: Anupama Gupta <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anupama Gupta <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 18:19:42 +0000 Gerrit-HasComments: No
