Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10502 )
Change subject: [java] Add Timestamp APIs to kudu-client ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/10502/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@586 PS1, Line 586: * @param columnName name of the column to get data for > I don't think java.sql.Timestamp objects have time zones. A timezone is onl Woops you're absolutely right. Got myself confused reading JDK docs yesterday. http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java File java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java: http://gerrit.cloudera.org:8080/#/c/10502/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestTimestampUtil.java@50 PS2, Line 50: public void testNonZuluTimestampConversion() throws Exception { Is this testing any Kudu functionality? I was pretty thoroughly confused when I suggested the non-zulu timestamp test (given Timestamp instances don't have timezones). -- To view, visit http://gerrit.cloudera.org:8080/10502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fdd397691f12f279663838af9fa12ed27508fd1 Gerrit-Change-Number: 10502 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 15:22:47 +0000 Gerrit-HasComments: Yes
