Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10524 )
Change subject: KUDU-2438 Class relocation in the maven build should be ...................................................................... Patch Set 2: > Patch Set 2: > > Dan, you have moved the relocation from the parent to kudu-client and because > of that, the kudu-flume-sink which also uses guava skips the relocation step > and references the original classes. I think the reasoning back then was that guava was provided by flume, so we should just use that version (and indeed, it's in provided scope). FWIW I think your change makes things cleaner overall, especially since you should now be able to remove a lot of the shading configuration from individual submodules, right? Also, could you add the specific issues the current config causes to the commit message, e.g. is this cleaning up un-necessary jars in the uberjar (as shown by jar -tf or similar), or something else? -- To view, visit http://gerrit.cloudera.org:8080/10524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib24a990544c58a46c08df673050543a67b0babf9 Gerrit-Change-Number: 10524 Gerrit-PatchSet: 2 Gerrit-Owner: Ferenc Szabo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Ferenc Szabo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 15:44:28 +0000 Gerrit-HasComments: No
