Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10336 )
Change subject: [rebalancing] add a rebalancing algorithm ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/10336/18/src/kudu/tools/rebalance_algo.h File src/kudu/tools/rebalance_algo.h: http://gerrit.cloudera.org:8080/#/c/10336/18/src/kudu/tools/rebalance_algo.h@148 PS18, Line 148: Status GetIntersection( : ExtremumType extremum, : const ServersByCountMap& servers_by_table_replica_count, : const ServersByCountMap& servers_by_tota > After some consideration, I decided to leave this as is for now. Ack http://gerrit.cloudera.org:8080/#/c/10336/19/src/kudu/tools/rebalance_algo.cc File src/kudu/tools/rebalance_algo.cc: http://gerrit.cloudera.org:8080/#/c/10336/19/src/kudu/tools/rebalance_algo.cc@88 PS19, Line 88: DCHECK(found_src && found_dst); since you're handling this case now, maybe remove this? http://gerrit.cloudera.org:8080/#/c/10336/19/src/kudu/tools/rebalance_algo.cc@117 PS19, Line 117: Value of '0' is a shortcut for 'the possible maximum'. do we need this? if so, please doc this -- To view, visit http://gerrit.cloudera.org:8080/10336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a8050ee79117a2ae2f6f88740ed25656946cfb4 Gerrit-Change-Number: 10336 Gerrit-PatchSet: 19 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 07 Jun 2018 02:44:28 +0000 Gerrit-HasComments: Yes
