Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10582 )
Change subject: KUDU-2191: use 'kudu_only' in metadata upgrade tool ...................................................................... Patch Set 2: > The LSAN failure looks legit. Also, why does tool_action_hms > include a test header (client-test-util.h)? Why is this new > function defined in a test header? > The LSAN failure looks legit. Also, why does tool_action_hms > include a test header (client-test-util.h)? Why is this new > function defined in a test header? tool_action_hms includes client-test-util.h because it uses a util method SchemaFromKuduSchema defined in client-test-util, but maybe it would make more sense to move them all to sth like client-util.h? -- To view, visit http://gerrit.cloudera.org:8080/10582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51d4cabeb1a9defc51f4e307a116419da5588f2d Gerrit-Change-Number: 10582 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 07 Jun 2018 18:35:09 +0000 Gerrit-HasComments: No
