David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10650 )
Change subject: wip tablet: add tmeta manager ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/master/sys_catalog.cc@180 PS1, Line 180: RETURN_NOT_OK(tablet::TabletMetadata::Load( : fs_manager, tmeta_manager_.get() do we seil need to pass both the fs and the tmeta managers? thought the tmeta was supposed to be a proxy of the fs manager http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet-test.cc File src/kudu/tablet/tablet-test.cc: http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet-test.cc@54 PS1, Line 54: #include "kudu/tablet/tablet_meta_manager.h" hum, we need this include even without further changes? http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_meta_manager.cc File src/kudu/tablet/tablet_meta_manager.cc: http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_meta_manager.cc@34 PS1, Line 34: XX(awong): it would be nice if this were decoupled from SuperBlockPB. why? http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_metadata.h@76 PS1, Line 76: FsManager* fs_manager, do we really need to pass in the fs manager here? http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/10650/1/src/kudu/tablet/tablet_metadata.cc@84 PS1, Line 84: FsManager* fs_manager, it's a bummer that we still need to pass this in. do we rely on the fact that the fs_manager instance inside tmeta_manager is the same as the above one? it seems that we're conflating metadata and data concerns inside tabletmetadata, could we split those up? as a last resort, I saw that you only use the dd_manager from the impl. could we only pass that one in? -- To view, visit http://gerrit.cloudera.org:8080/10650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If664082cca3ae2e20f74364a15533d13f99a7757 Gerrit-Change-Number: 10650 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 08 Jun 2018 21:48:31 +0000 Gerrit-HasComments: Yes
