Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10667 )
Change subject: [tools] ksck: fix some output spacing and printing of GetFlags warnings ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10667/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10667/1/src/kudu/tools/ksck.cc@222 PS1, Line 222: s = master->FetchUnusualFlags(); : if (!s.ok()) { > Might be missing something, but does this change do anything? Same below. Before, the printing was conditioned on the success of FetchUnusualFlags but that status was not set into s, so the ToString of the Status chain on L202 was printed instead. This was usually Status::OK() so an empty line was printed whenever GetFlags failed. -- To view, visit http://gerrit.cloudera.org:8080/10667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a7772a2d25d934ce42b27fbb81a5711cb4f12cd Gerrit-Change-Number: 10667 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 11 Jun 2018 17:17:07 +0000 Gerrit-HasComments: Yes
