David Ribeiro Alves has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10695 )

Change subject: scripts: tool to plot metrics
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10695/1/src/kudu/scripts/plot_metrics.py
File src/kudu/scripts/plot_metrics.py:

http://gerrit.cloudera.org:8080/#/c/10695/1/src/kudu/scripts/plot_metrics.py@51
PS1, Line 51: to
remove


http://gerrit.cloudera.org:8080/#/c/10695/1/src/kudu/scripts/plot_metrics.py@64
PS1, Line 64: of
over?


http://gerrit.cloudera.org:8080/#/c/10695/1/src/kudu/scripts/plot_metrics.py@176
PS1, Line 176: rate_metrics = [("tablet.rows_inserted", "inserts_per_sec")]
nit: make this the default for rate_metric?



--
To view, visit http://gerrit.cloudera.org:8080/10695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia39b23331bb105a0eb1782be5acd7450df43db3c
Gerrit-Change-Number: 10695
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 12 Jun 2018 15:36:25 +0000
Gerrit-HasComments: Yes

Reply via email to