Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10698 )
Change subject: [tools] Add simple util for version parsing ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/CMakeLists.txt@475 PS2, Line 475: ADD_KUDU_TEST(version_util-test) > What's this doing here? Shouldn't it be above with the rest of the regular Done http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/version_util.h@35 PS2, Line 35: ToolVersionInfo > Maybe just Version? The unparsed format is super generic and can be applied Done http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/10698/2/src/kudu/util/version_util.cc@46 PS2, Line 46: return os << Substitute("major: $0, minor: $1, maintenance: $2, extra: $3", > You wouldn't prefer just spitting out the raw version? I implemented it for the ASSERT_EQ macros, where it's good to be totally clear about what field is what. Can do just the raw version as well. -- To view, visit http://gerrit.cloudera.org:8080/10698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bcf3b10b699e89ad489144611990702dec8af19 Gerrit-Change-Number: 10698 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 13 Jun 2018 06:46:22 +0000 Gerrit-HasComments: Yes
