Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 )
Change subject: KUDU-2191 (12/n): Hive Metastore notification log event listener ...................................................................... Patch Set 28: (5 comments) http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/catalog_manager.cc@1745 PS27, Line 1745: // renamed in the HMS. > Nit: actually, here "lower" was correct, because the sentence was "this mak Done http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/catalog_manager.cc@1748 PS27, Line 1748: // Look up and lock the table. > We're not actually marking the table as removed; that's done later in respo Done http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/catalog_manager.cc@2133 PS27, Line 2133: // alteration to a table which has just been renamed or deleted through the HMS. > Same. Done http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/hms_notification_log_listener.cc File src/kudu/master/hms_notification_log_listener.cc: http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/hms_notification_log_listener.cc@129 PS27, Line 129: > So if we wake up because Shutdown() was called, we'll still do one more Pol Done http://gerrit.cloudera.org:8080/#/c/8313/27/src/kudu/master/hms_notification_log_listener.cc@229 PS27, Line 229: } : : // Failing to properly handle a notification is not a fatal error, instead : // we continue processing notifications. Callers of WaitForCatchUp have no : // way of indicating which specific notification they are waiting for, and : // returning early with error pertaining to > We talked about this on Slack. Done -- To view, visit http://gerrit.cloudera.org:8080/8313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775 Gerrit-Change-Number: 8313 Gerrit-PatchSet: 28 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 13 Jun 2018 23:09:29 +0000 Gerrit-HasComments: Yes
