Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8313 )
Change subject: KUDU-2191 (12/n): Hive Metastore notification log event listener ...................................................................... Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/8313/35/src/kudu/master/hms_notification_log_listener-test.cc File src/kudu/master/hms_notification_log_listener-test.cc: http://gerrit.cloudera.org:8080/#/c/8313/35/src/kudu/master/hms_notification_log_listener-test.cc@33 PS35, Line 33: Are these timing tests robust? Do they pass when looped in TSAN mode with some stress threads? http://gerrit.cloudera.org:8080/#/c/8313/35/src/kudu/master/hms_notification_log_listener-test.cc@35 PS35, Line 35: HmsNotificationLogListenerTest I think we like to have test fixtures inherit from KuduTest even if they don't need any functionality there. Can't remember why though. That said, it does look like there's some commonality that could be stored in a test fixture. The creation of the listener, for one. And poll_period too. -- To view, visit http://gerrit.cloudera.org:8080/8313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ed099c44a593ffe514152135957018f21ed775 Gerrit-Change-Number: 8313 Gerrit-PatchSet: 35 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 14 Jun 2018 23:55:34 +0000 Gerrit-HasComments: Yes
