Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10728 )
Change subject: KUDU-2191: Correct error handling in Metadata upgrade tool ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10728/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10728/1/src/kudu/tools/tool_action_hms.cc@163 PS1, Line 163: WARN_NOT_OK(AlterKuduTable(kudu_client, new_table_name, table_name), > Yeah, actually I found the test is not correctly structured to test the rol I'm not sure. I think it's worth keeping the test you have, and perhaps giving it a more descriptive name of what properties it's testing. As far as how to test the rollback, nothing bullet proof is coming to mind. Maybe you could get creative and introduce some faults / shutdown the HMS in another thread? -- To view, visit http://gerrit.cloudera.org:8080/10728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1d3ae49e03f5c3cc809846fee4fcde885aff25f Gerrit-Change-Number: 10728 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 19 Jun 2018 22:18:28 +0000 Gerrit-HasComments: Yes
