Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10770 )
Change subject: KUDU-2480: tsan failure of master-stress-test ...................................................................... KUDU-2480: tsan failure of master-stress-test This is an attempt to fix the race reported in KUDU-2480. I've been unable to reproduce the race on dist-test, however after auditing the code mentioned the the stack traces I saw this bit of fishy code. My current theory is that it's illegal to call Synchronizer::AsStatusCallback twice on one synchronizer, which was accidentally happening due to some dead code. This may or may not fix the race, but it's a mistake worth fixing nonetheless. Change-Id: I6b5103242aa24ffa81813d8e6ab5df630c69c8cf Reviewed-on: http://gerrit.cloudera.org:8080/10770 Reviewed-by: Mike Percy <[email protected]> Reviewed-by: Hao Hao <[email protected]> Tested-by: Dan Burkert <[email protected]> --- M src/kudu/master/hms_notification_log_listener.cc 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Mike Percy: Looks good to me, approved Hao Hao: Looks good to me, but someone else must approve Dan Burkert: Verified -- To view, visit http://gerrit.cloudera.org:8080/10770 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6b5103242aa24ffa81813d8e6ab5df630c69c8cf Gerrit-Change-Number: 10770 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]>
